The center for all Wikitravel images!

Tech:HTML tables broken

From Wikitravel Shared
Jump to: navigation, search

Moved from en:Wikitravel:Bug reports by Evan

What happens[edit]

The upgrade seems to have broken something in the HTML table parser. Consider the following:

<table border=1><tr><td>foo</table>

Which is now generates:


And look how the table doesn't end at all, until I punch in a </td></tr></table>. </td></tr></table>

en:Wikitravel:Multilingual statistics is now pretty badly broken because of this. Jpatokal 11:06, 13 April 2006 (EDT)

I don't know what to tell you. That's incorrect HTML, which you should be avoiding anyways, and I guess the parser got stricter about it in the 1.6.x upgrade. Is it possible to change the statistics bot to generate Wikitext tables rather than HTML ones? --Evan 12:31, 13 April 2006 (EDT)
To be precise, this is correct HTML (See specs). It is not correct in XHTML. BTW, external link icon is missning (just after specs), or just I cant see it? --JanSlupski 18:44, 13 April 2006 (EDT)
I see it. Good point, it is valid HTML. I'll see what I can do. --Evan 19:13, 13 April 2006 (EDT)
I've now revised Multilingual stats to use Wikitext syntax, which solves the immediate problem, but are there other HTML tables lurking about in the depths of Wikitravel? At least the country infoboxes seem to be working fine. Jpatokal 23:04, 13 April 2006 (EDT)
Wow, great job! I'm glad you got that converted so quickly.
I've been looking in the code for MediaWiki to see how HTML parsing has changed, and I have to admit that the MW parser scares the pants off of me. I think that as of now the easiest thing to do is to upgrade HTML tables to Wikitext ones where we can.
I saw at least en:Burgundy today. That doesn't look like incorrect HTML, although I could be reading it wrong. --Evan 23:11, 13 April 2006 (EDT)
FYI, this is a pretty handy tool for converting HTML tables into Wiki markup. 01:16, 14 April 2006 (EDT)

When it happens[edit]

What should happen[edit]

How to fix it[edit]

Seems to have been fixed by a MW upgrade (I presume?), as at least the example above is working fine again. Jpatokal 05:26, 29 September 2006 (EDT)