"Wikitravel has a speed and convenience the books' publishers can only envy." Time Europe

Tech:Listings - Can't edit some listings using form

From Wikitravel Shared
Revision as of 15:15, 28 August 2008 by LtPowers (Talk | contribs)

(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to: navigation, search

What happens[edit]

I manually added four hotel listings to the article en:Saint Marys (Pennsylvania) (that is, I filled in the fields in the <sleep> tags myself rather than using the form). Now, if I try to use the "edit" link to edit the listings using the form, the third and fourth listings work fine, but the first and second do not. Instead of the form, I get the message "Listing has been changed by somebody else. Please reload the page and reedit."

When it happens[edit]

I can't tell what the difference is between the listings that work and the ones that don't.

What should happen[edit]

The form should work correctly for all listings, even if they're added manually.

How to fix it[edit]

Additional comments[edit]

BTW: If I had to point to an example of what I like to see in a bug report, this is it. KevinSours 18:03, 25 August 2008 (EDT)

What can I say? I'm a software engineer. =) LtPowers 19:27, 25 August 2008 (EDT)

Solution[edit]

Some of the values in the listing were not being correctly handled and therefore didn't make it into the js object that runs the listing form. The result is that when we check back with the server the values are different and it triggers a check that makes sure that we don't overwrite a listing in the (hopefully rare) case of simultaneous edits. Should be fixed now on review. I have a couple more things to finish up before I push the listing changes live, but hopefully that will happen soon.KevinSours 18:05, 25 August 2008 (EDT)

Should now be live KevinSours 16:52, 27 August 2008 (EDT)

Looks good, thanks! LtPowers 11:11, 28 August 2008 (EDT)

Sign below, please[edit]

-- LtPowers 15:59, 25 August 2008 (EDT)

Variants

Actions

In other languages